fix: update Europe funding option label - #2298

Claude finished @wired-pasteque's task in 3m 17s —— View job

PR Review: update Europe funding option label

• Read PR diff and changed files
• Trace label usage in the Flutter code
• Check translation consistency across all 27 locales
• Validate ARB structure / formatting
• Post review

The intent (rename the Europe "Instant SEPA" funding option) is clear and consistently applied across all 27 locales. A few things are worth a look before merging.

🔴 Main concern — new label conflicts with the still-present "Regular SEPA" option

lib/features/fund_exchange/presentation/widgets/fund_exchange_europe_methods.dart renders two tiles:

So the screen now shows both "Instant & Regular SEPA" and a separate "Regular SEPA" tile, and the first tile's own subtitle still restricts it to amounts below €30,000 — which contradicts the "& Regular" part of its new title. This reads as redundant/confusing to the user.

If the goal was to merge the two methods into one, the RegularSepa tile (and the …InstantSepaSubtitle text) should change too. If the two methods are meant to stay separate, the InstantSepa label probably shouldn't claim "& Regular". Worth confirming against the intent in #2183. Fix this →

🟡 Translation inconsistencies

• app_es.arb also changed fundExchangeMethodRegularSepa ("SEPA regular" → "SEPA estándar"), but English and the other 25 locales leave fundExchangeMethodRegularSepa unchanged. The RegularSepa key should be updated either everywhere or nowhere, otherwise Spanish drifts from the rest.
• app_fr.arb uses "SEPA régulier et instantané" (Regular & Instant) — order is reversed vs the English "Instant & Regular SEPA". Minor, but worth aligning.

🟡 Stale @… metadata in non-English files

The English @fundExchangeMethodInstantSepa.description was updated to "Payment method: Instant & Regular SEPA (Europe)", but non-template files (e.g. app_ar.arb) still carry the old "Payment method: Instant SEPA (Europe)" description block. gen_l10n only reads metadata from the template (app_en.arb), so this is harmless at runtime — just stale.

🟡 Trailing newline removed

Several files lost their final newline (\ No newline at end of file), e.g. app_de.arb, app_fr.arb, app_hy.arb, app_ka.arb, app_sw.arb, app_vi.arb. Cosmetic, but it adds lint noise and will cause noisy diffs later. Recommend restoring the trailing newline.

✅ Other notes

• Unrelated whitespace/indentation fixes (fundExchangeErrorTitleOrdPo404, fundExchangeErrorOrdPo404) are bundled in — harmless cleanups, just out of scope.
• No security concerns; ARB JSON structure is intact.

Verdict: Functionally low-risk (string-only), but the label/option mismatch in point 1 is a real UX inconsistency and the Spanish RegularSepa drift should be resolved before merge.
· branch funding-option-label

@claude, this is working as intended. The two options are separate methods - "Instant & Regular SEPA" for under €30k, "Regular SEPA" for above. The overlap in naming is expected

Claude finished @wired-pasteque's task in 26s —— View job

Re: "Instant & Regular SEPA" vs "Regular SEPA"

Thanks for the clarification, @wired-pasteque — that makes sense. Two distinct methods split by the €30,000 threshold, with the naming overlap being intentional. I'll consider point 1 resolved; no change needed there.

A couple of the minor (🟡) items from my earlier review are still worth a quick look before merge — none are blockers:

• app_es.arb drift — this PR also renamed fundExchangeMethodRegularSepa ("SEPA regular" → "SEPA estándar") in Spanish only, while the English template and the other 25 locales leave that key untouched. Since the Regular SEPA method isn't being renamed, this looks like an unintended change. Recommend reverting the Spanish fundExchangeMethodRegularSepa to keep it aligned. Fix this →
• Trailing newlines — several files lost their final newline (app_de.arb, app_fr.arb, app_hy.arb, app_ka.arb, app_sw.arb, app_vi.arb). Cosmetic, but restoring them avoids lint noise and noisy future diffs.

The French word-order nit and stale non-template @…description metadata are harmless (metadata is only read from app_en.arb at runtime) — feel free to ignore.

Everything else looks good. ✅

--- · branch funding-option-label